Skip to content

inline default_lib_name_for_config_file#6046

Merged
ngoldbaum merged 1 commit into
PyO3:mainfrom
davidhewitt:default-lib-name-for-config
May 14, 2026
Merged

inline default_lib_name_for_config_file#6046
ngoldbaum merged 1 commit into
PyO3:mainfrom
davidhewitt:default-lib-name-for-config

Conversation

@davidhewitt
Copy link
Copy Markdown
Member

This changes InterpreterConfig::from_pyo3_config_file_env to apply the default lib name directly inside that function.

Before #5862 this wasn't possible.

@davidhewitt davidhewitt requested a review from ngoldbaum May 14, 2026 17:17
@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label May 14, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will create unknown performance changes

⚠️ No benchmarks were detected in both the base of the PR and the PR.
Please ensure that your benchmarks are correctly instrumented with CodSpeed.

Check out the benchmarks creation guide


Comparing davidhewitt:default-lib-name-for-config (2a46d04) with main (ad7d450)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just rebased my branch from #5807 on this PR and everything seems to be working.

@ngoldbaum ngoldbaum added this pull request to the merge queue May 14, 2026
Merged via the queue into PyO3:main with commit 598a454 May 14, 2026
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants