fix PyFrame::builtins type confusion issue#6052
Merged
Merged
Conversation
Tpt
approved these changes
May 17, 2026
Contributor
Tpt
left a comment
Tpt
left a comment
There was a problem hiding this comment.
nit: Can we add a #[should_panic] test?
bschoenmaeckers
approved these changes
May 17, 2026
ngoldbaum
approved these changes
May 18, 2026
Contributor
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
Thanks! Just one suggestion about the error message otherwise I'd add it to the merge queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6048