Skip to content

fix: delete_existing=False raises AttributeError - #3325

Open
Icebluewolf wants to merge 5 commits into
masterfrom
fix/delete_existing
Open

fix: delete_existing=False raises AttributeError#3325
Icebluewolf wants to merge 5 commits into
masterfrom
fix/delete_existing

Conversation

@Icebluewolf

Copy link
Copy Markdown
Member

Summary

Solves a bug where setting delete_existing=False in sync_commands or register_commands would result in an AttributeError. I improved the typing of the code that I touched. I also narrowed the types.interactions import to only include necessary structures. This PRs goal was to fix the issue and not try to refactor to make the code cleaner.
Fixes #3277

Generative AI was not used. Pycharms default single token autocomplete was used.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • I have read the Contributing Guidelines.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@Icebluewolf
Icebluewolf requested review from a team and vmphase August 3, 2026 01:22
@Icebluewolf Icebluewolf linked an issue Aug 3, 2026 that may be closed by this pull request
@Icebluewolf
Icebluewolf requested review from DA-344 and Lumabots August 3, 2026 01:22
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Aug 3, 2026
@Icebluewolf
Icebluewolf requested a review from JustaSqu1d August 3, 2026 01:22
@Icebluewolf
Icebluewolf requested a review from a team as a code owner August 3, 2026 01:22
@pycord-app

pycord-app Bot commented Aug 3, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3325/head:pr-3325
git checkout pr-3325

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3325/head

Comment thread discord/bot.py Outdated
Comment thread discord/bot.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Setting delete_existing=False in sync_commands causes an error.

2 participants