Possible bug in Resampler#148
Open
nzqo wants to merge 2 commits into
Open
Conversation
Collaborator
|
My apologies for the delay, I've been on travel for a bit. Thanks for pointing out this issue, in any case. I'd like to investigate a bit further before I say something wrong, but I think there may indeed be a bit of a problem here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering the mus are not ordered, should one not use the mask to specify the remaining kernel locations around which there is still sampling to be done? In the simplest case, assume that only the last particle location in mu yields an invalid particle location when drawing, then in the current situation the algorithm would resample from a gaussian centered around the first location mu[0], not the last.
Edit: tried to add a fix