Update PQK tutorial to conform to new template#4948
Conversation
|
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 One or more of the following people are relevant to this code:
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Comment 1:
Comment 2: Comment 3: |
|
Thank you for the review, here is the summary of updates:
Please let me know if any other changes are needed. |
| "\n", | ||
| "## Background\n", | ||
| "\n", | ||
| "*Usage estimate: 80 minutes on a Heron r3 processor (NOTE: This is an estimate only. Your runtime might vary.)*\n", |
There was a problem hiding this comment.
Yes, this is a duplicate, I remove it on my latest commit.
- Remove duplicate usage estimate from Background section - Promote Requirements and Setup to h2 headings - Move "If you found this work interesting" lead-in outside the Next steps admonition
There was a problem hiding this comment.
LGTM! Thanks for the changes @MeltemTolunay! I added a review minor changes to make the tutorial more consistent with the template and the other tutorials.
| "If you found this work interesting, you might be interested in the following material:\n", | ||
| "- In-depth [quantum machine learning course](https://quantum.cloud.ibm.com/learning/en/courses/quantum-machine-learning) from IBM Quantum Learning Platform\n", | ||
| "- [Quantum kernel training](https://quantum.cloud.ibm.com/docs/en/tutorials/quantum-kernel-training) tutorial" | ||
| "<Admonition type=\"tip\" title=\"Recommendations\">\n", |
There was a problem hiding this comment.
For consistency, we should put the "If you found this work interesting" line inside the Admonition box (so just switch lines 1501 and 1502). After that is done it's good from my end! @nathanearnestnoble do you need to review?
There was a problem hiding this comment.
Got it, I will revert that change. I originally did that before since the tutorial template had it outside.
No description provided.