-
Notifications
You must be signed in to change notification settings - Fork 193
Update content on responsible quantum pg #5153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c76a91d
bring in new content from Ryan and Genya
abbycross 9453a7d
Merge branch 'main' into ajc/resp-computing
abdonrd 3a8adad
try removing standalone parens
abbycross 7749346
Merge branch 'main' into ajc/resp-computing
abbycross c93e896
Merge branch 'ajc/resp-computing' of https://github.com/Qiskit/docume…
abbycross 64d47df
Fix PR preview build when only root-level docs files change
abdonrd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR preview build was failing because
scripts/pr-previews/builder.pydrops_toc.jsonandindex.*files from any section that has no changed files in this PR.The copytree ignore filter adds the entire subdirectory (e.g.
docs/guides,learning/courses/*) to the ignore list when nothing inside it changed, so copytree never descends into it, and the rules meant to always preserve_toc.jsonandindex.*never get a chance to run. With no_toc.jsonfiles copied, the Next.js app's/api/toc/[[...tocPath]]route can't generate static params duringoutput: export, producing the misleading error:This only surfaces when a PR's only changes are in files at the root of
docs/(likeresponsible-quantum-computing.mdx), which is why other PRs build fine.Fix: copy all
_toc.jsonandindex.*files explicitly after the copytree pass, alongside the existing hardcoded list. The ignore filter is simplified since those special cases are no longer needed there.