feat(argocd): add manifest view#2684
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an ArgoCD “Manifest” view for ARGOCD_APP services in the Console, reuses a shared resource sidebar/tree component across ArgoCD and Terraform UIs, and makes small UI refinements (accordion trigger icon styling + input rounding) with corresponding snapshot updates.
Changes:
- Add ArgoCD manifest page (route + UI) with Live/Target state toggle and resource list/search.
- Move/introduce a shared
ResourceTreeListcomponent into@qovery/shared/console-sharedand reuse it in Terraform resources. - Add
isArgoCdtype guard + ArgoCD manifest query key/hook wiring in services data-access/feature layers.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Bumps lockfile entries for axios and qovery-typescript-axios. |
| package.json | Updates axios and qovery-typescript-axios versions used by the app. |
| libs/shared/ui/src/lib/components/inputs/input-search/input-search.tsx | UI tweak: use rounded-md for consistent input styling. |
| libs/shared/ui/src/lib/components/accordion/accordion.tsx | Adds iconClassName to customize accordion trigger icon styling. |
| libs/shared/console-shared/src/lib/resource-tree-list/resource-tree-list.tsx | Introduces shared ResourceTreeList (accordion-based grouping + search matching logic). |
| libs/shared/console-shared/src/lib/resource-tree-list/resource-tree-list.spec.tsx | Updates tests for the shared resource tree behavior/styling. |
| libs/shared/console-shared/src/index.ts | Exports the new shared ResourceTreeList. |
| libs/domains/services/feature/src/lib/service-overview/service-overview.tsx | Uses isArgoCd helper for ArgoCD-specific overview behavior. |
| libs/domains/services/feature/src/lib/service-overview/service-header/service-header.tsx | Replaces local pattern matching with isArgoCd helper. |
| libs/domains/services/feature/src/lib/select-commit-modal/snapshots/select-commit-modal.spec.tsx.snap | Snapshot update due to InputSearch styling change. |
| libs/domains/services/feature/src/lib/hooks/use-argocd-manifest/use-argocd-manifest.ts | Adds react-query hook for fetching ArgoCD manifest. |
| libs/domains/services/feature/src/lib/argocd-manifest/argocd-manifest.tsx | Adds ArgoCD Manifest page UI (resource tree + code viewer + live/target toggle). |
| libs/domains/services/feature/src/lib/argocd-manifest/argocd-manifest.spec.tsx | Adds unit tests for manifest adapter + UI states. |
| libs/domains/services/feature/src/index.ts | Exports ArgoCD manifest hook and component. |
| libs/domains/services/data-access/src/lib/domains-services-data-access.ts | Adds isArgoCd type guard + services.argocdManifest query definition. |
| libs/domains/service-terraform/feature/src/lib/terraform-resources-section/terraform-resources-section.tsx | Switches Terraform resources UI to use shared ResourceTreeList and shared sidebar styling. |
| libs/domains/service-terraform/feature/src/index.ts | Removes export of old, Terraform-local resource tree list. |
| libs/domains/organizations/feature/src/lib/**/snapshots/*.snap | Snapshot updates due to InputSearch styling change. |
| apps/console/src/routes/_authenticated/organization/route.tsx | Uses isArgoCd for service tab selection logic. |
| apps/console/src/routes/_authenticated/organization/.../service/.../manifest.tsx | Implements manifest route: fetch service summary, gate to ArgoCD, render manifest with Suspense loader. |
| apps/console/src/routes/_authenticated/organization/.../environment/.../overview/route.tsx | Uses isArgoCd for counts + adjusts heading text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2684 +/- ##
===========================================
+ Coverage 45.18% 45.22% +0.04%
===========================================
Files 1153 1157 +4
Lines 24119 24178 +59
Branches 7027 7055 +28
===========================================
+ Hits 10897 10934 +37
- Misses 11314 11327 +13
- Partials 1908 1917 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ted control styling
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ccessibility and interaction
96155fe to
1744e9d
Compare
…rom ArgoCdManifest for improved error handling and cleaner API
…o prevent potential runtime errors
Summary
ARGOCD_APPservicesResourceTreeListto console-sharedScreenshots / Recordings
ArgoCD
Terraform
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release