Skip to content

feat(argocd): add manifest view#2684

Open
RemiBonnet wants to merge 11 commits into
stagingfrom
feat/argocd-manifest
Open

feat(argocd): add manifest view#2684
RemiBonnet wants to merge 11 commits into
stagingfrom
feat/argocd-manifest

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented May 13, 2026

Summary

  • Add ArgoCD Manifest page for ARGOCD_APP services
  • Add toggle to the diff between live and current version
  • Move shared ResourceTreeList to console-shared
  • Reuse the shared sidebar for Terraform resources

Screenshots / Recordings

ArgoCD

Screenshot 2026-05-15 at 10 46 50

Terraform

Screenshot 2026-05-13 at 16 36 30

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet marked this pull request as ready for review May 13, 2026 14:33
@RemiBonnet RemiBonnet requested a review from Copilot May 13, 2026 14:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an ArgoCD “Manifest” view for ARGOCD_APP services in the Console, reuses a shared resource sidebar/tree component across ArgoCD and Terraform UIs, and makes small UI refinements (accordion trigger icon styling + input rounding) with corresponding snapshot updates.

Changes:

  • Add ArgoCD manifest page (route + UI) with Live/Target state toggle and resource list/search.
  • Move/introduce a shared ResourceTreeList component into @qovery/shared/console-shared and reuse it in Terraform resources.
  • Add isArgoCd type guard + ArgoCD manifest query key/hook wiring in services data-access/feature layers.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yarn.lock Bumps lockfile entries for axios and qovery-typescript-axios.
package.json Updates axios and qovery-typescript-axios versions used by the app.
libs/shared/ui/src/lib/components/inputs/input-search/input-search.tsx UI tweak: use rounded-md for consistent input styling.
libs/shared/ui/src/lib/components/accordion/accordion.tsx Adds iconClassName to customize accordion trigger icon styling.
libs/shared/console-shared/src/lib/resource-tree-list/resource-tree-list.tsx Introduces shared ResourceTreeList (accordion-based grouping + search matching logic).
libs/shared/console-shared/src/lib/resource-tree-list/resource-tree-list.spec.tsx Updates tests for the shared resource tree behavior/styling.
libs/shared/console-shared/src/index.ts Exports the new shared ResourceTreeList.
libs/domains/services/feature/src/lib/service-overview/service-overview.tsx Uses isArgoCd helper for ArgoCD-specific overview behavior.
libs/domains/services/feature/src/lib/service-overview/service-header/service-header.tsx Replaces local pattern matching with isArgoCd helper.
libs/domains/services/feature/src/lib/select-commit-modal/snapshots/select-commit-modal.spec.tsx.snap Snapshot update due to InputSearch styling change.
libs/domains/services/feature/src/lib/hooks/use-argocd-manifest/use-argocd-manifest.ts Adds react-query hook for fetching ArgoCD manifest.
libs/domains/services/feature/src/lib/argocd-manifest/argocd-manifest.tsx Adds ArgoCD Manifest page UI (resource tree + code viewer + live/target toggle).
libs/domains/services/feature/src/lib/argocd-manifest/argocd-manifest.spec.tsx Adds unit tests for manifest adapter + UI states.
libs/domains/services/feature/src/index.ts Exports ArgoCD manifest hook and component.
libs/domains/services/data-access/src/lib/domains-services-data-access.ts Adds isArgoCd type guard + services.argocdManifest query definition.
libs/domains/service-terraform/feature/src/lib/terraform-resources-section/terraform-resources-section.tsx Switches Terraform resources UI to use shared ResourceTreeList and shared sidebar styling.
libs/domains/service-terraform/feature/src/index.ts Removes export of old, Terraform-local resource tree list.
libs/domains/organizations/feature/src/lib/**/snapshots/*.snap Snapshot updates due to InputSearch styling change.
apps/console/src/routes/_authenticated/organization/route.tsx Uses isArgoCd for service tab selection logic.
apps/console/src/routes/_authenticated/organization/.../service/.../manifest.tsx Implements manifest route: fetch service summary, gate to ArgoCD, render manifest with Suspense loader.
apps/console/src/routes/_authenticated/organization/.../environment/.../overview/route.tsx Uses isArgoCd for counts + adjusts heading text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 80.30303% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.22%. Comparing base (fed6600) to head (a316e85).

Files with missing lines Patch % Lines
...eature/src/lib/argocd-manifest/argocd-manifest.tsx 83.72% 1 Missing and 6 partials ⚠️
...b/hooks/use-argocd-manifest/use-argocd-manifest.ts 0.00% 4 Missing ⚠️
.../src/lib/resource-tree-list/resource-tree-list.tsx 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2684      +/-   ##
===========================================
+ Coverage    45.18%   45.22%   +0.04%     
===========================================
  Files         1153     1157       +4     
  Lines        24119    24178      +59     
  Branches      7027     7055      +28     
===========================================
+ Hits         10897    10934      +37     
- Misses       11314    11327      +13     
- Partials      1908     1917       +9     
Flag Coverage Δ
unittests 45.22% <80.30%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet force-pushed the feat/argocd-manifest branch from 96155fe to 1744e9d Compare May 15, 2026 08:50
…rom ArgoCdManifest for improved error handling and cleaner API
@RemiBonnet RemiBonnet requested a review from rmnbrd May 15, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants