fix(button): standardize icon alignment in buttons and update spacing guidelines, tokens update on some components#2687
Open
TheoGrandin74 wants to merge 4 commits into
Open
fix(button): standardize icon alignment in buttons and update spacing guidelines, tokens update on some components#2687TheoGrandin74 wants to merge 4 commits into
TheoGrandin74 wants to merge 4 commits into
Conversation
…e spacing guidelines, tokens update on some components
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2687 +/- ##
===========================================
- Coverage 45.18% 44.72% -0.46%
===========================================
Files 1153 1093 -60
Lines 24119 23117 -1002
Branches 7027 6760 -267
===========================================
- Hits 10897 10338 -559
+ Misses 11314 10985 -329
+ Partials 1908 1794 -114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ndardize spacing across various components
RemiBonnet
approved these changes
May 15, 2026
Member
RemiBonnet
left a comment
There was a problem hiding this comment.
LGTM 👍 Could you fix the conflict before merging ? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-alignattributes for icons, for a consistent alignment across the whole console + facilitate future changes if we needScreenshots / Recordings
Before

After

Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release