Skip to content

fix(button): standardize icon alignment in buttons and update spacing guidelines, tokens update on some components#2687

Open
TheoGrandin74 wants to merge 4 commits into
stagingfrom
style/tokens-improvments
Open

fix(button): standardize icon alignment in buttons and update spacing guidelines, tokens update on some components#2687
TheoGrandin74 wants to merge 4 commits into
stagingfrom
style/tokens-improvments

Conversation

@TheoGrandin74
Copy link
Copy Markdown
Contributor

@TheoGrandin74 TheoGrandin74 commented May 15, 2026

Summary

  • Updated button component to match design -> smaller buttons were using text-xs when they should have used text-ssm from the get go. Should make the icons and text in small buttons more easily readable, especially in some tables like the service or environment list
  • Updated button components to use data-align attributes for icons, for a consistent alignment across the whole console + facilitate future changes if we need
  • Migrated all existing buttons with a text+icon to the new behavior
  • Updated the tokens in some pages where it was the wrong token used
  • Updated the bad alignement on some callouts I've spotted (from align-center to align-top on the icon for callout with big wall of text)
  • Updated the design skill to keep the new behavior in mind

Screenshots / Recordings

Before
image

After
image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.72%. Comparing base (fed6600) to head (8465d4a).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
.../database-rds-dashboard/database-rds-dashboard.tsx 0.00% 2 Missing ⚠️
...ib/service/service-dashboard/service-dashboard.tsx 0.00% 2 Missing ⚠️
...ects/feature/src/lib/project-list/project-list.tsx 0.00% 2 Missing ⚠️
...dit-logs/feature/src/lib/audit-logs/audit-logs.tsx 0.00% 1 Missing ⚠️
...ture/src/lib/step-personalize/step-personalize.tsx 0.00% 1 Missing ⚠️
...ainer-registries/settings-container-registries.tsx 0.00% 1 Missing ⚠️
...s-helm-repositories/settings-helm-repositories.tsx 0.00% 1 Missing ⚠️
...re/src/lib/auto-deploy-badge/auto-deploy-badge.tsx 0.00% 1 Missing ⚠️
...ed/ui/src/lib/components/button/button.stories.tsx 0.00% 1 Missing ⚠️
...i/src/lib/components/table-filter/table-filter.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2687      +/-   ##
===========================================
- Coverage    45.18%   44.72%   -0.46%     
===========================================
  Files         1153     1093      -60     
  Lines        24119    23117    -1002     
  Branches      7027     6760     -267     
===========================================
- Hits         10897    10338     -559     
+ Misses       11314    10985     -329     
+ Partials      1908     1794     -114     
Flag Coverage Δ
unittests 44.72% <23.52%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Could you fix the conflict before merging ? Thanks!

@RemiBonnet RemiBonnet changed the title refactor(components): standardize icon alignment in buttons and update spacing guidelines, tokens update on some components fix(button): standardize icon alignment in buttons and update spacing guidelines, tokens update on some components May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants