Respect outside regular hours in fill models#9483
Open
aiSynergy37 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates fill eligibility to respect order-level outside regular trading hours settings when the order properties expose that setting. This prevents extended-hours subscriptions from filling orders that explicitly disallow outside regular trading hours.
The shared exchange-open helper now applies the order property override before checking market hours, and short bars no longer use the large-bar boundary fallback when the exchange is closed at the order time.
Related Issue
Fixes #9476
Motivation and Context
A stop market order submitted during pre-market data could fill when the subscription had extended market hours enabled, even if the order property set
OutsideRegularTradingHours = false.Requires Documentation Change
No
How Has This Been Tested?
dotnet build Tests\QuantConnect.Tests.csproj --no-restore -v minimal /p:RunAnalyzers=falseTypes of Changes