bbh_michigan_monthly: state the measured ~825 KB transfer in the docstring - #104
Merged
Conversation
…tring The #96 validation instrumented the builder's HTTP traffic: 1 API GET (4,181 B) plus 6 range requests totalling 820,763 B = 824,944 bytes, ~2.6x the docstring's "~310 KiB". The builder is genuinely range-based (no full-archive fallback ran); the gap is the 256 KiB read buffer each member is streamed through. Documentation-only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the bbh_michigan_monthly builder’s module docstring to reflect the measured HTTP transfer size observed during validation (#96/#97), clarifying why the transfer exceeds the compressed member sizes while keeping builder behavior unchanged.
Changes:
- Revise the “Network cost” docstring section to report the measured ~825 KB transfer and attribute the overshoot to buffered range reads.
- Preserve the existing claim that the builder uses HTTP Range requests with a full-download fallback.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot review: the paragraph states the deposit in IEC units (189 MiB, 256 KiB, ~310 KiB) but the measured transfer was added as decimal "~825 KB". Exact bytes (824,944) sidestep the unit mix and match the instrumented figure in the #96 validation record verbatim. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instrumented run in the #96 validation measured 824,944 bytes total (1 API GET of 4,181 B plus 6 range requests totalling 820,763 B) against the docstring's "~310 KiB". The range-reading claim and byte-for-byte reproduction both verified; the gap is the 256 KiB buffer each of the three members is read through, so the docstring now states the measured transfer and why it overshoots the compressed member bytes. Documentation-only — no behavior change.
Closes #97
🤖 Generated with Claude Code