7 leaf proofs#569
Open
illuzen wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this also needs to update to latest qp-zk-circuits after release
Note
Medium Risk
Changes compile-time wormhole circuit parameters and proof batch size, which affects on-chain aggregated proof verification compatibility until fixtures and downstream qp-zk-circuits versions are aligned.
Overview
This PR lowers the default wormhole aggregation batch from 16 to 7 leaf proofs when
build.rsgenerates embedded ZK circuit binaries (QP_NUM_LEAF_PROOFSstill overridable via env). The comment documents the tradeoff: 7 leaves stay atdegree_bits=15(~1.5 GB peak) for mobile; 8+ needs a larger circuit (~2.5 GB).Workspace and
pallet-wormholedev-dependencies addqp-wormhole-aggregatorandqp-wormhole-inputs(plus circuit-builder in tests) to support an ignoredregenerate_test_fixturetest that rebuilds circuits at 7 leaves, proves/aggregates a sample transfer, and rewritestest-data/aggregated.hex. A localcompute_zk_leaf_hashhelper keeps fixture generation aligned with the circuit.Note for reviewers: after this lands, run the ignored fixture generator (or refresh
aggregated.hexmanually) so tests/benchmarks thatinclude_str!the hex proof match the new binaries; the PR description also calls for bumping to the latestqp-zk-circuitsrelease when available.Reviewed by Cursor Bugbot for commit 8110b33. Bugbot is set up for automated code reviews on this repo. Configure here.