Fix interrupting update#214
Open
marmarek wants to merge 2 commits into
Open
Conversation
This was referenced Jun 2, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026060401-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests46 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 16 fixed
Unstable testsDetails
Performance TestsPerformance degradation:23 performance degradations
Remaining performance tests:88 tests
|
This was referenced Jun 2, 2026
Add disk2 status and update volume retrieval method
QubesOS/qubes-desktop-linux-i3-settings-qubes#23
Open
When SIGINT is sent during last qube in a given group (admin, template/standalone, derived), given group isn't really interrupted, so none of the returned update status is FinalStatus.CANCELLED. This meant that update cancel request was canceled in practice and the update proceeded to the next group uninterrupted. And also that overall exit code didn't inform about the cancellation request. Fix this by returning EXIT.SIGINT if SIGINT was received, instead of checking if any update was actually cancelled. And then check for the EXIT.SIGINT status between update groups. Fixes QubesOS/qubes-issues#10900
Now that canceling updates actually prevents starting further updates, test that has some cancelled qubes didn't finish all expected updates. Adjust the test to not generate cancelled statuses unless explicitly expected.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 71.95% 71.74% -0.21%
==========================================
Files 12 12
Lines 1330 1338 +8
==========================================
+ Hits 957 960 +3
- Misses 373 378 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jun 4, 2026
tests: do not fail dispvm+thunderbird test early if TB is not installed
QubesOS/qubes-core-admin#817
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SIGINT is sent during last qube in a given group (admin,
template/standalone, derived), given group isn't really interrupted, so
none of the returned update status is FinalStatus.CANCELLED. This meant
that update cancel request was canceled in practice and the update
proceeded to the next group uninterrupted. And also that overall exit
code didn't inform about the cancellation request.
Fix this by returning EXIT.SIGINT if SIGINT was received, instead of
checking if any update was actually cancelled. And then check for the
EXIT.SIGINT status between update groups.
Fixes QubesOS/qubes-issues#10900