Skip to content

log protocol error#801

Open
piotrbartman wants to merge 3 commits into
QubesOS:mainfrom
piotrbartman:pbs/log_protocol_error
Open

log protocol error#801
piotrbartman wants to merge 3 commits into
QubesOS:mainfrom
piotrbartman:pbs/log_protocol_error

Conversation

@piotrbartman
Copy link
Copy Markdown
Member

Don't suppress the protocol error message, but write it to the logs

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.12%. Comparing base (27f3571) to head (c7c5ab1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
qubes/devices.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #801   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files          61       61           
  Lines       14001    14001           
=======================================
  Hits         9818     9818           
  Misses       4183     4183           
Flag Coverage Δ
unittests 70.12% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-grande
Copy link
Copy Markdown
Contributor

ben-grande commented Apr 17, 2026

There is another PR that does return the exception back to the client and also logs the exception name (not the message):

See 63a406c and 247a9bd

It is planned to log the message once it passes review that no unsanitized or private information is being logged or sent to the client. For that, a fuzzer would be nice, but for now, I just have checked manually.

@ben-grande
Copy link
Copy Markdown
Contributor

Merge conflict since yesterday, as #751 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants