Tests for QubesOS/qubes-issues#7000#805
Draft
marmarek wants to merge 3 commits into
Draft
Conversation
Add it for default linux kernels that don't ship its own kernelopts-common.txt file. See d57ebc08f27b4c86e2488f56eddc29ce3ad8cff5 in linux-utils for full explanation.
The reason is no longer true, only some loop devices are excluded. QubesOS/qubes-issues#7000
losetup -d doesn't really remove the device node, but detaches it from the file. That means it's a CHANGE event, not REMOVE - add a test if this case is handled properly too. QubesOS/qubes-issues#7000
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
=======================================
Coverage 70.12% 70.12%
=======================================
Files 61 61
Lines 14001 14001
=======================================
Hits 9818 9818
Misses 4183 4183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual bug is not fixed yet...
QubesOS/qubes-issues#7000