Skip to content

APPENG-4525:Create a tekton task for running Evaluation#203

Merged
RedTanny merged 17 commits into
RHEcosystemAppEng:mainfrom
RedTanny:APPENG-4525
Jun 3, 2026
Merged

APPENG-4525:Create a tekton task for running Evaluation#203
RedTanny merged 17 commits into
RHEcosystemAppEng:mainfrom
RedTanny:APPENG-4525

Conversation

@RedTanny
Copy link
Copy Markdown
Collaborator

No description provided.

@RedTanny RedTanny changed the title Create a tekton task for running Evaluation APPENG-4525:Create a tekton task for running Evaluation Feb 19, 2026
@RedTanny
Copy link
Copy Markdown
Collaborator Author

/test vulnerability-analysis-on-pr

@RedTanny RedTanny force-pushed the APPENG-4525 branch 2 times, most recently from f48f631 to b662c7e Compare May 19, 2026 04:47
@RedTanny RedTanny force-pushed the APPENG-4525 branch 2 times, most recently from eb66db2 to a4bb13c Compare May 26, 2026 11:17
@RedTanny
Copy link
Copy Markdown
Collaborator Author

/test-heavy eval=on

2 similar comments
@RedTanny
Copy link
Copy Markdown
Collaborator Author

/test-heavy eval=on

@RedTanny
Copy link
Copy Markdown
Collaborator Author

/test-heavy eval=on

Copy link
Copy Markdown
Collaborator

@zvigrinberg zvigrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedTanny Great job and thank you.
Please see my comments.

logger = LoggingFactory.get_agent_logger(__name__)


#add documentation for the tool sort main reasults to dependencies ,next
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedTanny Please remove the comment.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread .tekton/on-pull-request.yaml Outdated
values:
- "true"
params:
- name: INTEGRATION_TEST_STATUS
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedTanny This param is not used

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread .tekton/on-cm-runner.yaml
Comment on lines +552 to +616
finally:
- name: post-cm-evaluation
when:
- input: $(tasks.integration-test.status)
operator: in
values:
- Succeeded
- Failed
- input: $(tasks.eval-feature-gate.results.enabled)
operator: in
values:
- "true"
params:
- name: INTEGRATION_TEST_STATUS
value: $(tasks.integration-test.status)
taskSpec:
params:
- name: INTEGRATION_TEST_STATUS
type: string
steps:
- name: report
image: quay.io/ecosystem-appeng/cve-evaluation:llama_prompt
env:
- name: EXPLOIT_IQ_API_BASE
valueFrom:
configMapKeyRef:
name: evaluation-config
key: EXPLOIT_IQ_API_BASE
- name: EXPLOIT_IQ_API_TOKEN
valueFrom:
secretKeyRef:
name: evaluation-secret
key: EXPLOIT_IQ_API_TOKEN
- name: NGC_API_KEY
valueFrom:
secretKeyRef:
name: evaluation-secret
key: NGC_API_KEY
- name: JUDGE_BASE_URL
valueFrom:
configMapKeyRef:
name: evaluation-config
key: JUDGE_BASE_URL
- name: JUDGE_MODEL
valueFrom:
configMapKeyRef:
name: evaluation-config
key: JUDGE_MODEL
- name: JUDGE_TEMPERATURE
valueFrom:
configMapKeyRef:
name: evaluation-config
key: JUDGE_TEMPERATURE
- name: JUDGE_TOP_P
valueFrom:
configMapKeyRef:
name: evaluation-config
key: JUDGE_TOP_P
args:
- --mode
- api
- --stages
- all
- --submit

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedTanny Why not creating a shared task post-cm-evaluation and used it accordingly in two pipelines? ( as this one is duplication).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread .tekton/on-cm-runner.yaml Outdated
@RedTanny RedTanny requested a review from zvigrinberg May 31, 2026 13:36
Copy link
Copy Markdown
Collaborator

@zvigrinberg zvigrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RedTanny RedTanny merged commit 24a2051 into RHEcosystemAppEng:main Jun 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants