-
Notifications
You must be signed in to change notification settings - Fork 129
Option to link MIGraphX to MSVC Runtime Library statically or dynamically #4839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apwojcik
wants to merge
30
commits into
develop
Choose a base branch
from
protobuf-v30
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7edb162
upgrade for protobuf v30 on Windows
apwojcik 3cba518
update licenses
apwojcik 76b408e
Merge branch 'develop' into protobuf-v30
causten 7b72158
Merge branch 'develop' into protobuf-v30
apwojcik c063a85
upgrade to use clang-cl
apwojcik 374d2f2
update licenses
apwojcik 3bf5a82
Merge branch 'develop' into protobuf-v30
apwojcik 9d035ca
add missing PRIVATE
apwojcik 872bc70
add missing setup functions
apwojcik 1fb8cea
incorporate review feedback
apwojcik 6de38aa
Merge branch 'develop' into protobuf-v30
apwojcik 7bb41fe
Revert "update licenses"
apwojcik b913f89
Revert "add missing setup functions"
apwojcik 4915986
revert changes
apwojcik 57e39cc
revert more changes
apwojcik 27b9335
revert even more changes
apwojcik c676017
the last revert of changes
apwojcik bd5129c
update licenses
apwojcik a252dfc
Merge branch 'develop' into protobuf-v30
apwojcik 9863ffc
Merge branch 'develop' into protobuf-v30
apwojcik 80a8abc
incorporate review feedback
apwojcik d58875f
revert update licenses
apwojcik 150dc52
Merge branch 'develop' into protobuf-v30
apwojcik 63f7267
change to MIGRAPHX_MSVC_STATIC_RUNTIME
apwojcik 20e5a2b
Update CMakeLists.txt
apwojcik 32ffe71
Merge branch 'develop' into protobuf-v30
apwojcik 6ba9a91
Merge branch 'develop' into protobuf-v30
apwojcik 2fc9406
incorporate review feedback
apwojcik 59ed1a8
Merge branch 'develop' into protobuf-v30
apwojcik 67a5fbc
incorporate review feedback
apwojcik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the description, like "Link MSVC runtime library statically instead of dynamically" instead of leaving blank?