[AIMIGRAPHX-1003] Add warnings for dim and value not set#4850
Open
eddieliao wants to merge 5 commits into
Open
[AIMIGRAPHX-1003] Add warnings for dim and value not set#4850eddieliao wants to merge 5 commits into
eddieliao wants to merge 5 commits into
Conversation
eddieliao
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Adds user-facing warnings to improve usability when ONNX model inputs have unresolved symbolic dimensions or when the driver runs with inputs that were not explicitly provided.
Changes:
- Emit a warning during ONNX parsing when symbolic dimension parameters are unbound (excluding “batch” dims).
- Emit a warning in the driver when program inputs are not explicitly set via fill/load options.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/onnx/onnx_parser.cpp |
Adds a pre-parse warning for unbound symbolic dimension parameters in graph inputs. |
src/driver/main.cpp |
Adds a warning when running with inputs that are not explicitly populated (fill/load). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4850 +/- ##
===========================================
+ Coverage 92.88% 92.95% +0.07%
===========================================
Files 587 587
Lines 30348 30376 +28
===========================================
+ Hits 28187 28234 +47
+ Misses 2161 2142 -19
🚀 New features to boost your workflow:
|
pfultz2
reviewed
May 7, 2026
| unset.insert(param.first); | ||
| if(unset.empty()) | ||
| return; | ||
| log::warn() << "Input(s) without explicit values: " << join_strings(std::move(unset), ", ") |
Collaborator
There was a problem hiding this comment.
Not all inputs require explicit values. Most dont require this. I think this warning is just too noisy.
Contributor
Author
There was a problem hiding this comment.
The idea was to warn when users didn't set values for inputs such as the attention_mask and hopefully reduce the amount of tickets coming to us. Not sure if there's a good list out there for such inputs that require very specific values, but if not I can remove this warning.
pfultz2
reviewed
May 7, 2026
| { | ||
| // Skip batch dims and dims that are already set | ||
| if(d.has_dim_param() and not contains(parser.dim_params, d.dim_param()) and | ||
| to_lower(d.dim_param()).find("batch") == std::string::npos) |
Collaborator
There was a problem hiding this comment.
The batch dimension is not always named batch so I dont think you can rely on that.
Contributor
Author
There was a problem hiding this comment.
How often would a batch dimension not contain the word "batch"? The only example I can think of right now would be just using "N", which I can add an edge case for if desired.
pfultz2
reviewed
May 7, 2026
Regressions detected 🔴 * No develop baseline was found for this PR's branch point; compared against the latest available develop run instead. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Warn the user when input dimensions or input values are not set, with the goal to improve usability.
Technical Details
Batch size is excluded from the warnings as it is common in most models and the default value of 1 typically works.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable