Skip to content

Clean up the #include dependencies for the instruction_ref #4860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apwojcik wants to merge 11 commits into
base: develop
Choose a base branch
from
+3 −5
Open

Clean up the #include dependencies for the instruction_ref #4860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7cf15f9
clean up the include graph for the instruction_ref
apwojcik May 8, 2026
e1eba54
update licenses
apwojcik May 8, 2026
8bf5d58
incorporate review feedback
apwojcik May 11, 2026
1dda815
Merge branch 'develop' into instruction_ref
apwojcik May 11, 2026
56f2b22
Merge branch 'develop' into instruction_ref
apwojcik May 11, 2026
76e3c5a
revert update licenses
apwojcik May 11, 2026
1d525b9
Merge branch 'develop' into instruction_ref
apwojcik May 13, 2026
90d0226
Merge branch 'develop' into instruction_ref
apwojcik May 14, 2026
1971211
update licenses
apwojcik May 14, 2026
5edfbab
incorporate review feedback
apwojcik May 14, 2026
5b22f6d
Merge branch 'develop' into instruction_ref
kahmed10 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/include/migraphx/instruction_ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,4 @@ struct hash<migraphx::instruction_ref>

} // namespace std

#ifdef _MSC_VER
#include <migraphx/instruction.hpp>
#endif

#endif
4 changes: 3 additions & 1 deletion test/promote_literals_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2015-2025 Advanced Micro Devices, Inc. All rights reserved.
* Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand All @@ -23,6 +23,8 @@
*/

#include <migraphx/promote_literals.hpp>
#include <migraphx/instruction_ref.hpp>
Copy link
Copy Markdown
Collaborator

@pfultz2 pfultz2 May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You dont need to include instruction_ref. The other headers already include it.

#include <migraphx/instruction.hpp>
Copy link
Copy Markdown
Collaborator

@pfultz2 pfultz2 May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This include should come after the migraphx/promote_literals.hpp include.

#include <migraphx/program.hpp>
#include <migraphx/dead_code_elimination.hpp>
#include <migraphx/eliminate_common_subexpression.hpp>
Expand Down
Loading