Skip to content

Replace deprecated __hip_atomic_* builtins with __scoped_atomic_* equivalents #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srinivamd wants to merge 1 commit into
base: develop
Choose a base branch
from
+10 −0
Open

Replace deprecated __hip_atomic_* builtins with __scoped_atomic_* equivalents #4902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/targets/gpu/kernels/include/migraphx/kernels/atomic.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,23 @@ MIGRAPHX_DEVICE_CONSTEXPR void cas(rank<1>, T& x, T y, Op op)
MIGRAPHX_ATOMIC_CAS_WARNING();
using storage = conditional_t<sizeof(T) == 4, uint32_t, uint64_t>;
storage* address = reinterpret_cast<storage*>(&x);
#if __has_builtin(__scoped_atomic_load_n)
storage expected = __scoped_atomic_load_n(address, __ATOMIC_RELAXED, __MEMORY_SCOPE_DEVICE);
while(not __scoped_atomic_compare_exchange(address,
&expected,
bit_cast<storage>(op(bit_cast<T>(expected), y)),
__ATOMIC_RELAXED,
__ATOMIC_RELAXED,
__MEMORY_SCOPE_DEVICE))
#else
storage expected = __hip_atomic_load(address, __ATOMIC_RELAXED, __HIP_MEMORY_SCOPE_AGENT);
while(not __hip_atomic_compare_exchange_strong(address,
&expected,
bit_cast<storage>(op(bit_cast<T>(expected), y)),
__ATOMIC_RELAXED,
__ATOMIC_RELAXED,
__HIP_MEMORY_SCOPE_AGENT))
#endif
{
}
}
Expand Down
Loading