Fix composable_kernel build with CMake 4.x (ROCM-24848)#4903
Open
srinivamd wants to merge 1 commit into
Open
Conversation
CMake 4.x (shipped in TheRock 7.14.0) removed compatibility with cmake_minimum_required < 3.5. The pinned composable_kernel revision (ad0db05) still declares an older minimum, causing cget builds to fail. This matches the existing pattern used for protobuf, nlohmann/json, and msgpack (added in PR #4714). Fixes: ROCM-24848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
-DCMAKE_POLICY_VERSION_MINIMUM=3.5to thecomposable_kernelentry inrequirements.txt, fixing the cget build failure with CMake 4.x.Problem
TheRock 7.14.0 ships CMake 4.x, which removed compatibility with
cmake_minimum_required< 3.5. Whenrbuild build -d dependrunscget installfor the pinnedROCm/composable_kernelrevision (ad0db05...), the build fails:The
-DCMAKE_POLICY_VERSION_MINIMUM=3.5flag on the top-levelrbuildcommand is not forwarded by cget to dependency builds.Fix
PR #4714 already added
-DCMAKE_POLICY_VERSION_MINIMUM=3.5to the protobuf, nlohmann/json, and msgpack entries inrequirements.txt. This PR applies the same pattern to thecomposable_kernelentry.Jira
Fixes ROCM-24848 — torch-migraphx image build fails on TheRock 7.14.0 (MI300/MI350, UB22/UB24).
Test
Build MIGraphX dependencies with CMake 4.x:
The composable_kernel dependency should now configure successfully.