[BACKPORT] Fix bert performance regressions on release branch#2327
Closed
umangyadav wants to merge 3 commits into
Closed
[BACKPORT] Fix bert performance regressions on release branch#2327umangyadav wants to merge 3 commits into
umangyadav wants to merge 3 commits into
Conversation
… bitcasts to reduce excessive codegen
* Fix barrier placement for scheduleVersion = 1. It should appear before LDSRead and not before GlobalLoad.
justinrosner
approved these changes
Apr 2, 2026
Contributor
justinrosner
left a comment
There was a problem hiding this comment.
Just cherry-picking some changes. Looks good to me
stefankoncarevic
approved these changes
Apr 6, 2026
Member
Author
|
Closing this one for #2331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry pick some fixes to fix performance on bert models
More details at ticket SWDEV-580287
This cherry pick brings back the performance and does a little better compared to QA's baseline