Skip to content

Add hipDNN examples#448

Open
adeljo-amd wants to merge 1 commit into
ROCm:amd-stagingfrom
adeljo-amd:hipdnn
Open

Add hipDNN examples#448
adeljo-amd wants to merge 1 commit into
ROCm:amd-stagingfrom
adeljo-amd:hipdnn

Conversation

@adeljo-amd
Copy link
Copy Markdown
Contributor

@adeljo-amd adeljo-amd commented May 6, 2026

Motivation

Add hipDNN examples to ROCm examples. Some examples were taken from the hipDNN repository and could be subject to change in the future given hipDNN's beta status.

Technical Details

  • Only targets ROCm and Linux, Windows and CUDA targets are omitted
  • Targets the latest API in hipDNN

Test Plan

Each example provides an option to validate its output.

Test Result

Should pass CI.

Added/Updated documentation?

  • Added new readmes for hipDNN

  • Yes

  • No, does not apply to this PR.

Included Visual Studio files?

  • Yes
  • No, does not apply to this PR.

Submission Checklist

@adeljo-amd adeljo-amd requested review from a team as code owners May 6, 2026 12:34
@adeljo-amd adeljo-amd force-pushed the hipdnn branch 4 times, most recently from 5a3793e to 62b485b Compare May 12, 2026 13:39
@adeljo-amd adeljo-amd changed the title Draft: Add hipDNN examples Add hipDNN examples May 12, 2026
Comment thread Libraries/hipDNN/conv_fprop/Makefile Outdated
@@ -0,0 +1,62 @@
# MIT License
#
# Copyright (c) 2025 Advanced Micro Devices, Inc. All rights reserved.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the makefile headers have the same license text as the other files from hipdnn?

// Copyright © Advanced Micro Devices, Inc., or its affiliates.
// SPDX-License-Identifier: MIT

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out, I believe the hipdnn source files should have the same license text as the makefile and others as that's what's used across the entire repo. I'll update this shortly

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated so all the files now use the same license text

@adeljo-amd
Copy link
Copy Markdown
Contributor Author

There seems to be some issue with fused_conv_fprop_activ on the tarball path that can also be observed in the rocm-libraries folder too - the wheel path passes though

Comment thread Libraries/hipDNN/bn_backward/CMakeLists.txt
Copy link
Copy Markdown
Collaborator

@zichguan-amd zichguan-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New examples are missing .gitignore file. Otherwise LGTM

@adeljo-amd
Copy link
Copy Markdown
Contributor Author

New examples are missing .gitignore file. Otherwise LGTM

Added

@adeljo-amd adeljo-amd requested a review from zichguan-amd May 14, 2026 23:42
Comment thread Libraries/Makefile Outdated
Copy link
Copy Markdown

@BrianHarrisonAMD BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM matches the repo samples, and was working from a nightly install of TheRock wheels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants