Use filter_hip_architectures for hipTensor examples#454
Open
mapatel-amd wants to merge 3 commits into
Open
Conversation
mapatel-amd
force-pushed
the
mapatel/hiptensor-arch-check
branch
from
9f7a9a9 to
e29951a
Compare
| endif() | ||
| endforeach() | ||
| include("${CMAKE_CURRENT_LIST_DIR}/../../../../../Common/FilterHIPArchitectures.cmake") | ||
| filter_hip_architectures("hipTensor" "gfx908;gfx90a;gfx942;gfx950" SHOULD_SKIP) |
Collaborator
There was a problem hiding this comment.
Same here, could we get these archs from hipTensor so we don't need to maintain the list here? Use something from hiptensorSupportedArchitectures.cmake
Collaborator
zichguan-amd
left a comment
zichguan-amd
left a comment
There was a problem hiding this comment.
Can you also look into the Makefiles with filter_hip_architectures.mk?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #333
Replaces the
hiptensor_is_supported_architectureper-arch loop in all hipTensor CMakeLists files with the sharedfilter_hip_architecturesutility introduced in 1d19858.Changes
CMakeLists.txtfiles updated (root + 20 sub-examples)gfx908;gfx90a;gfx942;gfx950sourced from hipTensor documentationBehaviour