[MIOPEN] Build only min required CK targets for MIOpen CI/CD#6431
Conversation
SreecharanGundaboluAMD
left a comment
There was a problem hiding this comment.
LGTM, thanks for making this change!
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (47.65%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6431 +/- ##
===========================================
- Coverage 66.58% 64.95% -1.63%
===========================================
Files 2176 2097 -79
Lines 320850 325473 +4623
Branches 41426 42685 +1259
===========================================
- Hits 213627 211398 -2229
- Misses 92619 96278 +3659
- Partials 14604 17797 +3193
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
BrianHarrisonAMD
left a comment
There was a problem hiding this comment.
LGTM
But likely out of date now.
ac300b0 to
0363260
Compare
|
@brockhargreaves-amd anything blocking this from being merged from your side? |
I think we also need to add it here: |
Oh you've done that already! Whoops! Yeah no issues on my end. |
Motivation
Reduce the CI time for miopen by avoiding building unnecessary code.
Follow up PR for "[ml-libs] Add THEROCK_COMPOSABLE_KERNEL_FOR_MIOPEN_ONLY flag (ROCm/TheRock#4435)"
Technical Details
Pass a flag to build only the minimum required portion of CK for MIOpen, when building TheRock for miopen CI tests.
Test Plan
Run CI/CD tests.
Test Result
Submission Checklist