Skip to content

[MIOPEN] Build only min required CK targets for MIOpen CI/CD#6431

Merged
evedovelli merged 15 commits into
developfrom
users/evedovel/hipdnn/ci-build-only-required-ck-targets
Jun 1, 2026
Merged

[MIOPEN] Build only min required CK targets for MIOpen CI/CD#6431
evedovelli merged 15 commits into
developfrom
users/evedovel/hipdnn/ci-build-only-required-ck-targets

Conversation

@evedovelli
Copy link
Copy Markdown
Contributor

@evedovelli evedovelli commented Apr 14, 2026

Motivation

Reduce the CI time for miopen by avoiding building unnecessary code.

Follow up PR for "[ml-libs] Add THEROCK_COMPOSABLE_KERNEL_FOR_MIOPEN_ONLY flag (ROCm/TheRock#4435)"

Technical Details

Pass a flag to build only the minimum required portion of CK for MIOpen, when building TheRock for miopen CI tests.

Test Plan

Run CI/CD tests.

Test Result

Submission Checklist

@evedovelli evedovelli self-assigned this Apr 14, 2026
@evedovelli evedovelli requested a review from a team as a code owner April 14, 2026 18:09
@github-actions github-actions Bot added github actions project: none Does not target any component labels Apr 14, 2026
@brockhargreaves-amd brockhargreaves-amd changed the title Build only min required CK targets for MIOpen on hipDNN CI/CD Build only min required CK targets for MIOpen CI/CD Apr 14, 2026
Copy link
Copy Markdown
Contributor

@SreecharanGundaboluAMD SreecharanGundaboluAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making this change!

@brockhargreaves-amd brockhargreaves-amd changed the title Build only min required CK targets for MIOpen CI/CD [MIOPEN] Build only min required CK targets for MIOpen CI/CD Apr 14, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (47.65%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6431      +/-   ##
===========================================
- Coverage    66.58%   64.95%   -1.63%     
===========================================
  Files         2176     2097      -79     
  Lines       320850   325473    +4623     
  Branches     41426    42685    +1259     
===========================================
- Hits        213627   211398    -2229     
- Misses       92619    96278    +3659     
- Partials     14604    17797    +3193     
Flag Coverage Δ *Carryforward flag
hipBLAS 90.67% <ø> (ø) Carriedforward from b683f89
hipBLASLt 43.47% <ø> (+3.52%) ⬆️ Carriedforward from b683f89
hipCUB 82.21% <ø> (ø) Carriedforward from b683f89
hipDNN 82.46% <ø> (-0.01%) ⬇️
hipFFT 54.82% <ø> (-0.17%) ⬇️ Carriedforward from b683f89
hipRAND 76.12% <ø> (ø) Carriedforward from b683f89
hipSOLVER 68.73% <ø> (?) Carriedforward from b683f89
hipSPARSE 84.70% <ø> (?) Carriedforward from b683f89
rocBLAS 48.12% <ø> (+<0.01%) ⬆️ Carriedforward from b683f89
rocFFT 47.65% <ø> (+0.15%) ⬆️ Carriedforward from b683f89
rocPRIM 38.96% <ø> (ø) Carriedforward from b683f89
rocRAND 57.06% <ø> (-0.04%) ⬇️ Carriedforward from b683f89
rocSOLVER 77.72% <ø> (?) Carriedforward from b683f89
rocSPARSE 71.33% <ø> (-0.17%) ⬇️ Carriedforward from b683f89
rocThrust ?

*This pull request uses carry forward flags. Click here to find out more.
see 993 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@brockhargreaves-amd brockhargreaves-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about the code below:

Comment thread .github/scripts/therock_matrix.py
Copy link
Copy Markdown
Contributor

@BrianHarrisonAMD BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But likely out of date now.

@evedovelli evedovelli disabled auto-merge April 28, 2026 19:26
@evedovelli evedovelli force-pushed the users/evedovel/hipdnn/ci-build-only-required-ck-targets branch from ac300b0 to 0363260 Compare May 6, 2026 17:24
@evedovelli evedovelli requested a review from ammallya May 6, 2026 17:35
@evedovelli
Copy link
Copy Markdown
Contributor Author

@brockhargreaves-amd anything blocking this from being merged from your side?

@brockhargreaves-amd
Copy link
Copy Markdown
Contributor

@brockhargreaves-amd anything blocking this from being merged from your side?

I think we also need to add it here:

   "miopen": {
        "cmake_options": [
            "-DTHEROCK_ENABLE_MIOPEN=ON",
            "-DTHEROCK_ENABLE_MIOPENPROVIDER=ON",
            "-DTHEROCK_ENABLE_COMPOSABLE_KERNEL=ON",
            "-DTHEROCK_COMPOSABLE_KERNEL_FOR_MIOPEN_ONLY=ON",
        ],

@brockhargreaves-amd
Copy link
Copy Markdown
Contributor

@brockhargreaves-amd anything blocking this from being merged from your side?

I think we also need to add it here:

   "miopen": {
        "cmake_options": [
            "-DTHEROCK_ENABLE_MIOPEN=ON",
            "-DTHEROCK_ENABLE_MIOPENPROVIDER=ON",
            "-DTHEROCK_ENABLE_COMPOSABLE_KERNEL=ON",
            "-DTHEROCK_COMPOSABLE_KERNEL_FOR_MIOPEN_ONLY=ON",
        ],

Oh you've done that already! Whoops! Yeah no issues on my end.

Copy link
Copy Markdown
Collaborator

@ammallya ammallya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evedovelli evedovelli enabled auto-merge (squash) May 6, 2026 18:03
@evedovelli evedovelli enabled auto-merge (squash) May 15, 2026 14:38
@evedovelli evedovelli merged commit 7de76a8 into develop Jun 1, 2026
364 of 369 checks passed
@evedovelli evedovelli deleted the users/evedovel/hipdnn/ci-build-only-required-ck-targets branch June 1, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants