[stinkytofu] RawAsmParser: block-comment-aware // and ; stripping#7728
Open
darrenhsieh-amd wants to merge 1 commit into
Open
[stinkytofu] RawAsmParser: block-comment-aware // and ; stripping#7728darrenhsieh-amd wants to merge 1 commit into
darrenhsieh-amd wants to merge 1 commit into
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
shared: stinkytofu
labels
Naive scan truncated `/* foo//bar */` at the inner `//`, leaving an unterminated `/*` that the assembler extended across following instructions. Add findLineCommentOutsideBlock helper; use it at all three comment-strip sites.
darrenhsieh-amd
force-pushed
the
users/darrenh/stinkytofu-fix-comment-strip
branch
from
59323c8 to
801013e
Compare
cycheng
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Block comments that contain
//(e.g./* temp = (wg//CU_Count) */, common when//denotes Python integer division in generated code) were truncated by the parser's naive//scan. The closing*/was dropped and an unterminated/*ended up in the output, which the downstream assembler then extended over the following instructions. This will silently dropping them from the resulting.co.Technical Details
findLineCommentOutsideBlockhelper: walks the line, skips/* … */blocks, returns first//or;position outside anyblock (or
npos).RawAsmParser::parseRawAsmString:preserveCommentscapture//strip +st.token:annotation parser;stripTest Plan
ctest all passed.
Round-trip a real kernel passed.
Submission Checklist