Skip to content

[CK] Grouped Convolution Global Load/Store instances#7734

Open
bartekxk wants to merge 28 commits into
developfrom
users/barkocot/global-load-ck-instances
Open

[CK] Grouped Convolution Global Load/Store instances#7734
bartekxk wants to merge 28 commits into
developfrom
users/barkocot/global-load-ck-instances

Conversation

@bartekxk
Copy link
Copy Markdown
Contributor

@bartekxk bartekxk commented May 25, 2026 •
edited
Loading

Motivation

Support global load and store in grouped convolutions using instance factory.

Technical Details

  • add new instances for each direction
  • add new tests for large cases

Test Plan

New test for large cases

Test Result

pending

Submission Checklist

bartekxk and others added 13 commits May 20, 2026 05:48
@bartekxk bartekxk self-assigned this May 25, 2026
@bartekxk bartekxk requested a review from a team as a code owner May 25, 2026 11:01
@bartekxk bartekxk force-pushed the users/barkocot/global-load-ck branch from 226711b to 157fda5 Compare May 25, 2026 21:08
@bartekxk bartekxk force-pushed the users/barkocot/global-load-ck-instances branch from cfcb45e to 8d59903 Compare May 26, 2026 12:15
Base automatically changed from users/barkocot/global-load-ck to develop May 27, 2026 08:21
@bartekxk bartekxk requested a review from Copilot May 29, 2026 12:40
Copilot AI reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@bartekxk bartekxk requested a review from Copilot May 29, 2026 13:30
Copilot AI reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

jakpiase
jakpiase approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I appreciate the effort, quite a lot of great work

@JonathanLichtnerAMD JonathanLichtnerAMD mentioned this pull request May 29, 2026
Open
7 tasks
@bartekxk bartekxk requested a review from Copilot May 30, 2026 15:19
Copilot AI reviewed May 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@bartekxk bartekxk force-pushed the users/barkocot/global-load-ck-instances branch from a98dc49 to b0b9b23 Compare May 31, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jakpiase jakpiase jakpiase approved these changes

Assignees

@bartekxk bartekxk

Labels

organization: ROCm project: composablekernel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bartekxk @jakpiase