rocfft: remove -fgpu-rdc from library build#7740
Open
evetsso wants to merge 1 commit into
Open
Conversation
Likely still has problems with kpack, and breaks code coverage builds.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7740 +/- ##
===========================================
- Coverage 61.94% 61.82% -0.12%
===========================================
Files 2086 2087 +1
Lines 357068 357196 +128
Branches 53779 53797 +18
===========================================
- Hits 221171 220818 -353
- Misses 117093 117612 +519
+ Partials 18804 18766 -38
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-fgpu-rdc likely still has problems with kpack, and it breaks code coverage builds.
Technical Details
The flag only was there to try to (imperfectly) help legacy callbacks, which are being deprecated anyway.
Test Plan
Run regular regression tests and check that code coverage CI jobs work.
Test Result
Tests pass.
Submission Checklist