rocfft: move file -> header embedding script to shared#7741
Open
evetsso wants to merge 1 commit into
Open
Conversation
The script is currently used to embed source code into rocFFT for runtime compilation, but will also be used for runtime compiling client code like callback functions.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7741 +/- ##
===========================================
+ Coverage 61.94% 61.96% +0.02%
===========================================
Files 2086 2086
Lines 357068 357068
Branches 53779 53779
===========================================
+ Hits 221171 221245 +74
+ Misses 117093 117033 -60
+ Partials 18804 18790 -14
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The script is currently used to embed source code into rocFFT for runtime compilation, but will also be used for runtime compiling client code like callback functions.
Test Plan
Should only affect the build with no visible effects, but regular unit tests will confirm.
Test Result
Tests pass.
Submission Checklist