ENH: Remove rtkAdditiveGaussianNoiseImageFilter to use the itk version#950
Open
axel-grc wants to merge 1 commit into
Open
ENH: Remove rtkAdditiveGaussianNoiseImageFilter to use the itk version#950axel-grc wants to merge 1 commit into
axel-grc wants to merge 1 commit into
Conversation
SimonRit
approved these changes
May 22, 2026
Collaborator
SimonRit
left a comment
SimonRit
left a comment
There was a problem hiding this comment.
Thanks! You can merge when it comes back green.
axel-grc
force-pushed
the
AdditiveGausianNoiseImageFilter
branch
2 times, most recently
from
8e7c994 to
a617669
Compare
SimonRit
reviewed
May 22, 2026
| #include "rtkSheppLoganPhantomFilter.h" | ||
| #include "rtkThreeDCircularProjectionGeometryXMLFile.h" | ||
|
|
||
| #include <itkAdditiveGaussianNoiseImageFilter.h> |
Collaborator
There was a problem hiding this comment.
I think we can drop the includes in each application as we have it in rtkGgoFunctions.h and itk::AdditiveGaussianNoise is no longer in this file. Can you remove all these useless includes please?
axel-grc
force-pushed
the
AdditiveGausianNoiseImageFilter
branch
2 times, most recently
from
b050109 to
331aa97
Compare
SimonRit
reviewed
May 22, 2026
|
|
||
| #include "rtkdrawgeometricphantom_ggo.h" | ||
| #include "itkImageFileWriter.h" | ||
| #include "rtkAdditiveGaussianNoiseImageFilter.h" |
Collaborator
There was a problem hiding this comment.
Sorry, this one is required. It's a style requirement ("include what you use") as you use AdditiveGaussianNoise in the file.
axel-grc
force-pushed
the
AdditiveGausianNoiseImageFilter
branch
from
331aa97 to
e7b5ec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #947