remove spiceypy dependency with updated lunarsky#1671
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 67 67
Lines 22845 22845
=======================================
Hits 22831 22831
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks @aelanman! Obviously tests won't pass until the new lunarsky version is released but it's nice to have this ready to go when it is released. There's several other places in the repo where the lunarsky dependency is set, so we'll need to update those as well. Off the top of my head that includes:
Maybe just search the repo to see if there are any more. We also usually put something in the changelog when we increase dependency versions, you can see examples in there from earlier lunarsky version bumps. |
|
Thanks for the reminder about the changelog @bhazelton ! I've added to that (and for pyuvsim) and updated the README and environment.yaml. |
|
The pyuvsim test errors are caused by pyuvsim assuming an older version of lunarsky. That will be fixed by a separate PR in that repo. I don't understand the hera_cal failures, I made an issue in that repo to ask about them: HERA-Team/hera_cal#1052 |
Description
The latest version of lunarsky drops the dependency on spiceypy. As a result, the try blocks that catch SPICEUnknownFrameErrors in unit tests can be removed. This also bumps the minimum version of lunarsky.
Motivation and Context
This cleans up code that will no longer be needed.
Build or continuous integration change checklist: