Log request origins - #941
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds request Origin header data into Rails’ controller instrumentation payload for API requests, enabling downstream structured logging (via Semantic Logger) to filter/group by request origin as requested in issue #1588.
Changes:
- Append
originto theprocess_action.action_controllerpayload for controllers inheriting fromApiControllerwhen the header is present. - Add request specs asserting the payload includes
originwhen provided and omits it otherwise.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/controllers/api_controller.rb | Overrides append_info_to_payload to include origin in the controller instrumentation payload when present. |
| spec/requests/api_controller_spec.rb | Adds request specs that subscribe to process_action.action_controller and validate presence/absence of the origin payload field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test coverage92.18% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-issues-158-fp2o1v
July 27, 2026 15:32
Inactive
zetter-rpf
approved these changes
Jul 28, 2026
zetter-rpf
left a comment
Contributor
There was a problem hiding this comment.
Nice, it's good to have an example of how to add something to the logs too.
I can deploy and check betterstack once merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
Originheader to the structured completed-request payload.ApiController.Originheader.