Skip to content

fix: explicitly set publicPath for static assets #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebjacobs merged 3 commits into from
Apr 16, 2025
Merged

fix: explicitly set publicPath for static assets #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0673008
refactor: remove unused STATIC_PATH from webpack config
sebjacobs Apr 15, 2025
d3083b6
refactor: group asset loading webpack config together
sebjacobs Apr 15, 2025
acaed96
fix: explicitly set publicPath for static assets
sebjacobs Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const HtmlWebpackPlugin = require('html-webpack-plugin');

const ScratchWebpackConfigBuilder = require('scratch-webpack-configuration');

// const STATIC_PATH = process.env.STATIC_PATH || '/static';
const ASSET_PATH = '/scratch-gui/';

const baseConfig = new ScratchWebpackConfigBuilder(
{
Expand All @@ -18,7 +18,6 @@ const baseConfig = new ScratchWebpackConfigBuilder(
.setTarget('browserslist')
.merge({
output: {
assetModuleFilename: 'static/assets/[name].[hash][ext][query]',
library: {
name: 'GUI',
type: 'umd2'
Expand All @@ -34,7 +33,11 @@ const baseConfig = new ScratchWebpackConfigBuilder(
.addModuleRule({
test: /\.(svg|png|wav|mp3|gif|jpg)$/,
resourceQuery: /^$/, // reject any query string
type: 'asset' // let webpack decide on the best type of asset
type: 'asset', // let webpack decide on the best type of asset
generator: {
filename: 'static/assets/[name].[hash][ext][query]',
publicPath: ASSET_PATH,
},
})
.addPlugin(new webpack.DefinePlugin({
'process.env.DEBUG': Boolean(process.env.DEBUG),
Expand Down
Loading