Skip to content

refactor: remove shed_writer method and its calls from Supervisor #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReagentX merged 1 commit into from
Jul 12, 2026
Merged

refactor: remove shed_writer method and its calls from Supervisor #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/supervisor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ impl Supervisor {
if let Some(i) = self.index_of(id) {
let mut t = self.tasks.remove(i);
t.terminate();
t.shed_writer();
self.graveyard.push(t);
}
}
Expand Down Expand Up @@ -382,7 +381,6 @@ impl Supervisor {
// would straight-SIGKILL stragglers of the old run.
let mut old = std::mem::replace(&mut self.tasks[i], fresh);
old.terminate();
old.shed_writer();
self.graveyard.push(old);
// Reset the fingerprint for the replacement task's screen.
if self.watched == Some(id) {
Expand Down
6 changes: 0 additions & 6 deletions src/task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,12 +389,6 @@ impl Task {
self.reaped
}

/// Release the PTY writer after removal while retaining the master for
/// process-group teardown.
pub fn shed_writer(&mut self) {
self.writer = Box::new(io::sink());
}

pub fn lifecycle(&self, now: Instant, idle_after: Duration) -> Lifecycle {
if self.finished.is_some() {
return if self.exit_code == Some(0) {
Expand Down
Loading