Fix empty spaces in shortname#155
Open
daniele-andreotti wants to merge 13 commits into
Open
Conversation
Coverage Report for CI Build 26099796377Coverage decreased (-0.2%) to 70.321%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
cekk
requested changes
Apr 1, 2026
Member
cekk
left a comment
cekk
left a comment
There was a problem hiding this comment.
And add a changelog and some tests please
| self.request.response.setStatus(400) | ||
|
|
||
| msg = "Il nome breve non deve contenere spazi" | ||
| raise BadRequest(msg) |
Member
There was a problem hiding this comment.
please use english as default, and translate it.
You don't need to set status and then raise the exception. BadRequest already set 400
| data = json_body(self.request) | ||
|
|
||
| short_name = data.get("id", None) | ||
| if short_name and " " in short_name: |
Member
There was a problem hiding this comment.
why not use check_alias and improve it with also this check?
| <plone:service | ||
| method="POST" | ||
| factory=".add.FolderPost" | ||
| for="Products.CMFCore.interfaces.IFolderish" |
Member
There was a problem hiding this comment.
Why only folderish? There are also non folderish contents.
Why not using an event handler instead of customizing a service?
Member
There was a problem hiding this comment.
This should also work on edit/rename or not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix empty spaces in shortname when a content is created