Skip to content

fix: send request from editor#313

Merged
iosypov merged 1 commit into
mainfrom
fix/editor-send-request
Jun 8, 2026
Merged

fix: send request from editor#313
iosypov merged 1 commit into
mainfrom
fix/editor-send-request

Conversation

@iosypov

@iosypov iosypov commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

What/Why/How?

Updated CSP policy for unblock request to cors.redocly.com

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@redocly redocly Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marketing-site AI Review: 🟢 Completed

Reunite Bot has reviewed your changes and found 2 potential issue(s).

Note

Low Risk

This is a minor and targeted change to the Content Security Policy (CSP) that allows client-side requests to Redocly subdomains. It carries minimal operational or security risk, as it permits connections to a known and trusted service without altering core application logic.

Overview

Updates the connect-src CSP directive in redocly.yaml to include https://*.redocly.com. This change unblocks cross-origin requests to Redocly services (e.g., cors.redocly.com), enabling the editor to successfully send requests.

Comment thread redocly.yaml
base-uri 'self';
connect-src
'self'
https://*.redocly.com

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard *.redocly.com is overly broad. Since the PR objective is to unblock cors.redocly.com, restrict it to that specific subdomain to follow the principle of least privilege and reduce exfiltration risks.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see problem to open all our subdomains here.

Comment thread redocly.yaml
base-uri 'self';
connect-src
'self'
https://*.redocly.com

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change in the global ** section likely won't fix the editor issue. The /editor path has its own CSP policy (line 281) which will continue to block requests to cors.redocly.com.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fixed.

@iosypov iosypov merged commit 56d01ab into main Jun 8, 2026
7 checks passed
@iosypov iosypov deleted the fix/editor-send-request branch June 8, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants