docs: add review guidelines and feedback routing for agents#108
Conversation
Add AGENTS.md and code_review.md so an automated reviewer (Codex) follows a single Conventional Comments specification, and the agent that fixes a pull request routes disagreements and judgement calls to the human maintainer instead of looping with the reviewer. Human merge stays the final gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAzVV5kTFuoTABDYZHSKR1
AGENTS.md carries the review-feedback escalation rules, but the acting agent reads CLAUDE.md and not necessarily AGENTS.md. Inline the essentials here and point to the full section, so the escalation and no-self-merge rules actually bind the agent that fixes a pull request. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAzVV5kTFuoTABDYZHSKR1
8f19f1e to
51ad235
Compare
|
@codex Any thoughts about that ? |
ThoughtsI do not see a blocking issue in the PR content from the context available here. The added guidance is coherent and internally consistent:
The only minor thought I had is non-blocking: the template syntax No code or documentation changes were necessary, so I did not commit or open a follow-up PR. Checks
|
A review noted that the `[(decorations)]` / `[discussion]` template could be read as if the square brackets were literal. State explicitly, in AGENTS.md and code_review.md, that `< >` is a placeholder and `[ ]` marks an optional part. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAzVV5kTFuoTABDYZHSKR1
|
Thanks for the read. The single non-blocking point — that the Generated by Claude Code |
Summary
Add repository guidelines that steer automated agents: how an automated reviewer (for example Codex) must format and select pull request review comments, and how the agent that fixes a pull request responds to that feedback. No library or user-facing behavior changes.
Type of change
Changes
code_review.md: the full Conventional Comments specification for pull request reviews — comment format, labels, decorations, blocking rules and finding selection — with examples grounded in this repository's API (Outcome,ErrorCode.Create,ErrorContext, GenDoc, theFCExxxanalyzers).AGENTS.md: the entry point for automated agents — project orientation, a mandatory inlined subset of the review rules, and a "Responding to review feedback" section that routes disagreements and human-judgement calls to@reefactand caps bot re-review cycles.CLAUDE.mdto the "Responding to review feedback" rules, with the essentials inlined so they bind the acting agent even ifAGENTS.mdis not read.Testing
dotnet build FirstClassErrors.slndotnet test FirstClassErrors.slnFirstClassErrors.Analyzers.UnitTests)Docs-only change — no build or test surface is touched, so the commands above were not run. Both commit messages were validated with
tools/commit-lint/lint-commit-message.sh(the same check CI runs on every pull request).Documentation
This pull request is itself contributor/agent-facing documentation and changes no user-facing behavior, so no README or French translation (
doc/README.fr.md) update is required.Related issues
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XAzVV5kTFuoTABDYZHSKR1
Generated by Claude Code