ci: assert the preview canary ran on the newest .NET major#115
Merged
Conversation
Reefact
force-pushed
the
claude/tooling-multi-target-runtime-p4fzmi
branch
from
1bae832 to
05596da
Compare
The canary printed the worker's runtime banner but never checked it: a green run
proved only that a target was documented, not that fce ran on the preview. If the
roll-forward env were ever dropped, fce would silently bind .NET 10, document the
target, and still pass green.
Capture fce's stderr and assert the worker banner reports the highest installed
major ("Documenting … on .NET <newest>."); a mismatch now fails the run. The fce
call is wrapped in set +e so a genuine failure still echoes its diagnostics before
the step reports.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015HeXL6s4yGMAgZitfWijs1
Reefact
force-pushed
the
claude/tooling-multi-target-runtime-p4fzmi
branch
from
05596da to
5921c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canary printed the worker's runtime banner but never checked it: a green run proved only that a target was documented, not that fce ran on the preview. If the roll-forward env were ever dropped, fce would silently bind .NET 10, document the target, and still pass green.
Capture fce's stderr and assert the worker banner reports the highest installed major ("Documenting … on .NET ."); a mismatch now fails the run. The fce call is wrapped in set +e so a genuine failure still echoes its diagnostics before the step reports.
Claude-Session: https://claude.ai/code/session_015HeXL6s4yGMAgZitfWijs1
Summary
Type of change
Changes
Testing
dotnet build FirstClassErrors.slndotnet test FirstClassErrors.slnFirstClassErrors.Analyzers.UnitTests)Documentation
doc/updateddoc/README.fr.md) updated if user-facing behavior changedRelated issues