rttr:AddTerrain() for MyMap.lua#1958
Draft
morganchristiansson wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's incredible how quick it is to make a proof of concept PR with AI.
Not tested at all yet.
But if you have some early thoughts - all feedback is welcome.
The idea is to enable map creators to use custom textures, from S2 gamedata or externally provided.
So they could provide zip with:
MyMap.lua calls
rttr.AddTerrain(filename = "MyMap.lbm")with a bunch of parameters to define extra textures.Changes:
PR is really small really.
Open questions:
Also reason for this PR is to get all pieces on the board while adding s25edit custom texture support. There is no rush at all to review & merge this, it's not ready.
As workaround data/RTTR/gamedata/world/greenland/wasteland/winterland.lua can be edited to support new textures without changes which should work for testing purposes, but is not ideal for distributing maps with custom textures if map creators start doing this.
My enthusiasm for this depends on enthusiasm of map creators to use custom textures.