Fix pyright standard mode type errors and add CI type checking#30
Merged
Conversation
- Fix OpenCV Scalar type mismatches by using tuples instead of bare ints for color/borderValue args (cv2.fillPoly, cv2.line, cv2.remap, etc.) - Fix numpy floating return type in _mad_sigma_1d - Add py.typed marker for PEP 561 compliance - Add pyright step to test workflow
Owner
|
Glad it's useful, thanks for the PR! LGTM so I'll just merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome library! Small PR to improve type checking for consumers.