Upgrade GitHub actions#333
Merged
Merged
Conversation
Collaborator
|
hi @hpoettker thanks for the proposal, would you update your fork from dev? There is a change in Readstat that was making tests fail (as you see currently for this PR), but it is now solved on dev. Also question: where are the warnings showing up? I was looking at the logs and somehow cannot find them. Thanks! |
30b6c75 to
c2fe95e
Compare
Contributor
Author
|
I've rebased on the latest dev commit. The warnings are visible on the summary page of the builds, e.g. the latest build of dev: https://github.com/Roche/pyreadstat/actions/runs/26032848270 They are in the bottom widget titled "Annotations". |
Collaborator
|
Perfect! Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build currently generates the following warning:
The action
microsoft/setup-msbuild@v2is only listed in the warning for the Windows build while the other two are listed for all builds.The proposed upgrades of the actions resolve the issue.