Skip to content

Upgrade GitHub actions#333

Merged
ofajardo merged 1 commit into
Roche:devfrom
hpoettker:upgrade-actions
May 18, 2026
Merged

Upgrade GitHub actions#333
ofajardo merged 1 commit into
Roche:devfrom
hpoettker:upgrade-actions

Conversation

@hpoettker
Copy link
Copy Markdown
Contributor

The build currently generates the following warning:

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-python@v5, microsoft/setup-msbuild@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

The action microsoft/setup-msbuild@v2 is only listed in the warning for the Windows build while the other two are listed for all builds.

The proposed upgrades of the actions resolve the issue.

@ofajardo
Copy link
Copy Markdown
Collaborator

hi @hpoettker thanks for the proposal, would you update your fork from dev? There is a change in Readstat that was making tests fail (as you see currently for this PR), but it is now solved on dev.

Also question: where are the warnings showing up? I was looking at the logs and somehow cannot find them. Thanks!

@hpoettker
Copy link
Copy Markdown
Contributor Author

I've rebased on the latest dev commit.

The warnings are visible on the summary page of the builds, e.g. the latest build of dev: https://github.com/Roche/pyreadstat/actions/runs/26032848270

They are in the bottom widget titled "Annotations".

@ofajardo
Copy link
Copy Markdown
Collaborator

Perfect! Thanks a lot!

@ofajardo ofajardo merged commit 7b90176 into Roche:dev May 18, 2026
3 checks passed
@hpoettker hpoettker deleted the upgrade-actions branch May 18, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants