Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions TimeOffApp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { TimeOffService } from './services/TimeOffService';
import { AppNotifier } from './notifiers/AppNotifier';
import { PostMessageSentHandler } from './handlers/PostMessageSentHandler';
import { TimeOffRepository } from './repositories/TimeOffRepository';
import { TimeOffCache } from './TimeOffCache';
import { UserService } from './services/UserService';
import { APP_SETTINGS, DEFAULT_TIME_OFF_REPLY_COOLDOWN_HOURS } from './helpers/AppSettings';

Expand Down Expand Up @@ -49,7 +48,6 @@ export class TimeOffApp extends App implements IPostMessageSent {
_environmentRead: IEnvironmentRead,
_configurationModify: IConfigurationModify,
): Promise<boolean> {
TimeOffCache.getInstance().invalidateCache();
return Promise.resolve(true);
}

Expand Down
43 changes: 0 additions & 43 deletions TimeOffCache.ts

This file was deleted.

24 changes: 2 additions & 22 deletions services/TimeOffService.ts
Original file line number Diff line number Diff line change
@@ -1,35 +1,15 @@
import { ITimeOff } from '../interfaces/ITimeOff';
import { ITimeOffRepository } from '../repositories/ITimeOffRepository';
import { TimeOffCache } from '../TimeOffCache';
import { ITimeOffService } from './ITimeOffService';

export class TimeOffService implements ITimeOffService {
constructor(private readonly repository: ITimeOffRepository) {}

public async saveTimeOff(timeOff: ITimeOff): Promise<boolean> {
const success = await this.repository.save(timeOff);

if (success) {
const cache = TimeOffCache.getInstance();
cache.invalidateUser(timeOff.coreUserId);
cache.set(timeOff.coreUserId, timeOff);
}

return success;
return this.repository.save(timeOff);
}

public async getTimeOffByUserId(coreUserId: string): Promise<ITimeOff | undefined> {
const cache: TimeOffCache = TimeOffCache.getInstance();
let timeOffData: ITimeOff | undefined = cache.get(coreUserId);

if (!timeOffData) {
timeOffData = await this.repository.findByUserId(coreUserId);

if (timeOffData) {
cache.set(coreUserId, timeOffData);
}
}

return timeOffData;
return this.repository.findByUserId(coreUserId);
}
}
Loading