fix(auth): reject OAuth promise when popup is closed without completing login#1275
Open
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Open
fix(auth): reject OAuth promise when popup is closed without completing login#1275deepak0x wants to merge 2 commits intoRocketChat:developfrom
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1274
The OAuth login in
loginWithRocketChatOAuth.tsreturns a promise that only has aresolvepath. If the user closes the popup without finishing login, thesetIntervaldetects it, cleans up the listener, and then does nothing. Promise just sits there.The caller in
ChatInput.jsdoesawait RCInstance.auth.loginWithRocketChatOAuth()inside a try/catch, but the promise never rejects so the catch never fires. User closes the popup and gets no feedback at all.This adds
rejectto the promise constructor and calls it when the popup closes without completing OAuth. The catch block inChatInput.jsruns now and the user sees an error message.