fix: ordinal suffix in date and background color - #7567
Open
OtavioStasiak wants to merge 5 commits into
Open
Conversation
Contributor
WalkthroughThe change adds localized long-date formatting and updates message separators with themed colors, padded labels, and rounded corners. ChangesDate separator formatting
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OtavioStasiak
had a problem deploying
to
approve_e2e_testing
August 11, 2026 21:58 — with
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
ios_build
August 11, 2026 21:59 — with
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
android_build
August 11, 2026 21:59 — with
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the ordinal day to the message date separator ("August 11th, 2026"), applied only in locales that use it, matching web, where date-fns
PPPcarries the ordinal in English while dayjs'LLnever does. Also restyles the dateinto a rounded pill using the secondary button tokens, following the web layout.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1489
How to test or reproduce
Screenshots
Light
Dark
Black
Types of changes
Checklist
Further comments
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style