Skip to content

feat: add tabular numbers - #7568

Open
OtavioStasiak wants to merge 4 commits into
developfrom
feat.add-tabular-numbers
Open

feat: add tabular numbers#7568
OtavioStasiak wants to merge 4 commits into
developfrom
feat.add-tabular-numbers

Conversation

@OtavioStasiak

@OtavioStasiak OtavioStasiak commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Enables Inter's tabular figures app-wide, so digits keep a fixed width in messages, the composer and timestamps.
Requires upgrading the bundled Inter from 3.019 to 4.1, whose tabular set redraws the 1 with a foot serif, matching web.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1490

How to test or reproduce

  • Open the app;
  • Go to room;
  • Type 1 and send a message;

Screenshots

Before After
Simulator Screenshot - iPhone 16 - 2026-08-11 at 19 16 34 Simulator Screenshot - iPhone 16 - 2026-08-11 at 19 14 13

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Style
    • Standardized numeral alignment across shared text elements.
    • Improved consistency in audio duration display and other numeric text.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Tabular numeral styling moves to the shared default text style. The audio duration style removes its local tabular-nums declaration.

Changes

Text style consistency

Layer / File(s) Summary
Centralize tabular numeral styling
app/views/Styles.ts, app/containers/AudioPlayer/styles.ts
The shared defaultTextStyle adds tabular-nums. The audio duration style removes its duplicate local variant.
Estimated code review effort: 1 (Trivial) ~2 minutes

Suggested labels: type: feature

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding tabular numbers across the app.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • NATIVE-1490: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

iOS Build Available

Rocket.Chat 4.76.0.109507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants