Some error fixes and improvements for documentation#43
Open
Rokory wants to merge 10 commits into
Open
Conversation
Adds requires to handle common errors. Changes logic for detection of IntuneWin32App for more reliability.
…y administrator requirement
There was a problem hiding this comment.
Pull request overview
This PR updates the Winget Intune Packager PowerShell script and documentation to improve UI validation, icon retrieval robustness, and user guidance for Entra app registration setup.
Changes:
- Added required-field validation for Intune Graph connection details in the GUI.
- Reworked warning propagation from Intune app creation and made icon download more defensive when no icon is available.
- Expanded README with Entra app registration prerequisites and ignored
config.envvia.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
sources/WingetIntunePackager.ps1 |
Adds GUI input validation, adjusts warning handling for packaging, improves icon fetching, bumps version, and adds a #Requires directive. |
README.md |
Adds Entra app registration prerequisite instructions (with a few typos to correct). |
.gitignore |
Ignores config.env to avoid committing local configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+306
to
+308
| if (-not [string]::IsNullOrEmpty($warning)) { | ||
| Start-PopUp $warning | ||
| } |
Comment on lines
+616
to
+619
| Add-IntuneWin32App @Win32AppArgs -WarningVariable warning | ||
| $warning | foreach-object { | ||
| Write-Warning ($warning -join "`n") | ||
| } |
|
|
||
| ## Prerequisites | ||
|
|
||
| Before using the tool, you must create an app registion in Entra: |
|
|
||
| 1. Open the **Microsoft Entra admin center** | ||
| 1. In Microsoft Entra admin center, click **App registrations**. | ||
| 1. In App registations, click **New registration**. |
| 1. Open the **Microsoft Entra admin center** | ||
| 1. In Microsoft Entra admin center, click **App registrations**. | ||
| 1. In App registations, click **New registration**. | ||
| 1. In Register an application, enter a **Name**, e.g., *WingetIntunepackager*. Leve **Supported account types** on **Single tenant only**. Under **Redirect URI (optional)**, select **Public client/native (mobile & desktop)** and enter **https://login.microsoftonline.com/common/oauth2/nativeclient**. Click **Register** |
Comment on lines
11
to
+14
| ### APP INFO ### | ||
|
|
||
| #Winget Intune Packager version | ||
| $Script:WingetIntunePackager = "1.2.2" | ||
| $Script:WingetIntunePackager = "1.2.3" |
Owner
|
Hi Rokory, Thanks a lot for your contribution 🙏 I used Copilot to review your PR, and it suggested several improvements. It actually created a separate PR (#44) with those changes instead of updating yours directly. I'd prefer to keep your PR as the main one, so could you take a look at #44 and let me know what you think? Thanks again for your work, really appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved the checks for installed modules and fixed some minor errors. Moreover, error handling, e.g. on missing permissions, is much more robust now.
Futhermore, I also improved the readme with instructions on how to create the app in Entra.