feat: sntrup with kem traits implemented and optimizations - #371
Open
mikelodder7 wants to merge 4 commits into
Open
feat: sntrup with kem traits implemented and optimizations#371mikelodder7 wants to merge 4 commits into
mikelodder7 wants to merge 4 commits into
Conversation
Signed-off-by: Mike Lodder <redmike7@gmail.com>
Signed-off-by: Mike Lodder <redmike7@gmail.com>
tarcieri
reviewed
Aug 10, 2026
Member
|
As a general comment: there's a lot going on in this PR (with over 8 klocs of additions) including quite a bit of unsafe code, although it's largely for SIMD it appears. |
Signed-off-by: Mike Lodder <redmike7@gmail.com>
Contributor
Author
|
Yes I agree. If you want, I can break it down into smaller PRs if you think that would be helpful. |
Member
|
That'd be great. It would be nice to have a PR with the IMO ideally each SIMD backend you add for a particular architecture would get its own PR too so they can be reviewed independent of each other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
kemcrate traits and speed ups for sntrup.