Open
Conversation
|
Nice! Maybe dumb question bc it might already be there: could you link the standard you’re following in the README, bc I can’t find it. Also where did the KAT blobs come from? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #1, this PR adds support for
GMACto RustCrypto.Prerequisite needed: This change will not build until RustCrypto/traits#2367 is released as version
0.11.3.As this is my first time contributing to a public rust project, please do not assume that any choices I made were based on strong consideration.
A few choices that I did make intentionally:
KeyIvInitbecause that seems most appropriate to the GMAC case.FixedOutputResetbecause resetting GMAC (to reuse the same IV) seems excessively dangerous.Clonebecause I think it may be sufficiently useful and safe on the verification path. It is also needed for testing. However, I'll happily make theClonetrait only implemented when compiling for test code if you determine it is too dangerous.Mactrait already exposesverify_truncated_leftwhich does what we'd need.Some specific questions:
DO NOT MERGE UNTIL
digestis released as0.11.3to fix tests