Reapply "srp: add HomeKit-compatible padding for u and M1/M2"#285
Merged
Conversation
Member
Author
|
cc @r4v3n6101 |
Contributor
|
The failure comes from switching u to the RFC-defined calculation, u = H(PAD(A) || PAD(B)). Previously, the code comment already described that formula, but the implementation was actually computing u = H(A || B) without padding. |
Member
Author
|
If you think the tests need to change, can you also update them? The biggest blocker here is the test failure. |
tarcieri
changed the title
mnvr
added a commit
to ente-io/ente
that referenced
this pull request
Apr 24, 2026
…es (#10195) Ref: - The run where I noticed this - https://github.com/ente-io/ente/actions/runs/24838660254/job/72706010895?pr=10185 - The upstream fix - RustCrypto/PAKEs#285 Since the upstream fix is unreleased, and also is part of a rc build that switches from digest 0.10 to 0.11, the diff in this branch is bigger than warranted. Even now, we'll have both digest's is the build until we bump the argon2 dep tree (there is an update available, but it is an rc, so for now I've let that argon2 bit keep using the old digest 0.10) --- Some unrelated formatting changes since I ran cargo fmt on the various crates that depend on ente-core as I went around building them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 22d096a (#283)
This was originally added in #272 then reverted due to bugs which weren't caught in CI at the time, but are now captured by proptests