Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions der/src/reader/slice.rs
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,20 @@ impl<'a> Reader<'a> for SliceReader<'a> {

let resumption = self.position.split_nested(len)?;
let ret = f(self);
let finished = self.is_finished();
let decoded = self.position.current();
let remaining = self.remaining_len();

self.bytes = bytes;
self.position.resume_nested(resumption);

if ret.is_ok() && !finished {
self.failed = true;
return Err(self
.error(ErrorKind::TrailingData { decoded, remaining })
.into());
};

ret
}

Expand Down Expand Up @@ -153,10 +165,10 @@ impl<'a> Reader<'a> for SliceReader<'a> {
}

#[cfg(test)]
#[allow(clippy::unwrap_used, clippy::panic)]
#[allow(clippy::unwrap_used, clippy::panic, reason = "tests")]
mod tests {
use super::SliceReader;
use crate::{Decode, ErrorKind, Length, Reader};
use crate::{Decode, Error, ErrorKind, Length, Reader};
use hex_literal::hex;

// INTEGER: 42
Expand Down Expand Up @@ -217,4 +229,26 @@ mod tests {
err.kind()
);
}

#[test]
fn nested_trailing_data() {
let der = hex!("0102");
let mut reader = SliceReader::new(&der).unwrap();

let err: Error = reader
.read_nested(2u8.into(), |reader| {
reader.read_slice(1u8.into())?;
Ok(())
})
.unwrap_err();

assert_eq!(Length::ONE, err.position().unwrap());
assert_eq!(
ErrorKind::TrailingData {
decoded: 1u8.into(),
remaining: 1u8.into(),
},
err.kind()
);
}
}