Skip to content

feat: [Orchestration] reasoning content #939

Merged
CharlesDuboisSAP merged 38 commits into
mainfrom
reasoning-content
Jul 24, 2026
Merged

feat: [Orchestration] reasoning content #939
CharlesDuboisSAP merged 38 commits into
mainfrom
reasoning-content

Conversation

@n-o-u-r-h-a-n

@n-o-u-r-h-a-n n-o-u-r-h-a-n commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Context

AI/ai-sdk-java-backlog#412.

As a user, I would like to see the thinking processes when using the reasoning models, in addition to the final outcome. This is relevant for synchronous and streaming use-cases.

The harmonized API of orchestration supports this feature (see link above), so the SDK should also follow.

Feature scope:

  • supported reasoning content using model classes code
  • added sample code as well as updated controller and index page
  • added e2e and unit tests

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

CharlesDuboisSAP
CharlesDuboisSAP reviewed Jul 9, 2026
View reviewed changes
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/AssistantMessage.java Outdated
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/AssistantMessage.java
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java Outdated
ZhongpinWang
ZhongpinWang reviewed Jul 9, 2026
View reviewed changes

@ZhongpinWang ZhongpinWang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CharlesDuboisSAP Regarding the signature, it does not need a convenience to get it out. It only needs to be as part of the message history and be sent back together in the next LLM call for verification reasons. So IMO providing a convenience to access reasoning content text would be enough.

Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/AssistantMessage.java Outdated
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/AssistantMessage.java Outdated
Jonas-Isr
Jonas-Isr reviewed Jul 14, 2026
View reviewed changes
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/AssistantMessage.java Outdated
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java Outdated
Comment thread sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java Outdated
Comment thread sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java Outdated
Comment thread sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java Outdated
Comment thread orchestration/src/test/resources/reasoningRequest.json
n-o-u-r-h-a-n and others added 7 commits July 14, 2026 13:11
@n-o-u-r-h-a-n
Merge branch 'main' into reasoning-content
55a0523
@n-o-u-r-h-a-n @Jonas-Isr
Update sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/contro…
6a3da98 
…llers/OrchestrationTest.java

Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
@n-o-u-r-h-a-n @Jonas-Isr
Update sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/contro…
8d3d2ca 
…llers/OrchestrationTest.java

Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
@n-o-u-r-h-a-n @Jonas-Isr
Update sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/contro…
49c4f2b 
…llers/OrchestrationTest.java

Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
@n-o-u-r-h-a-n
Merge branch 'main' into reasoning-content
3931633
@n-o-u-r-h-a-n
fixes
233b950
@n-o-u-r-h-a-n
wiring extra json files
6b5f4ab
Jonas-Isr
Jonas-Isr reviewed Jul 14, 2026
View reviewed changes
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/ReasoningAccumulator.java Outdated
CharlesDuboisSAP
CharlesDuboisSAP reviewed Jul 15, 2026
View reviewed changes
Comment thread ...le-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java
Comment thread ...le-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java Outdated
Comment thread sample-code/spring-app/src/main/resources/static/index.html Outdated
Comment thread sample-code/spring-app/src/main/resources/static/index.html Outdated
Comment thread sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java Outdated
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatCompletionDelta.java Outdated
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java Outdated
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/ReasoningEffort.java Outdated
@n-o-u-r-h-a-n @CharlesDuboisSAP
Update sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/contro…
59c8409 
…llers/OrchestrationController.java

Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
n-o-u-r-h-a-n and others added 3 commits July 16, 2026 13:01
@n-o-u-r-h-a-n
Merge branch 'main' into reasoning-content
e75a7e2
@n-o-u-r-h-a-n @CharlesDuboisSAP
Update sample-code/spring-app/src/main/resources/static/index.html
6e13d46 
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
@n-o-u-r-h-a-n @CharlesDuboisSAP
Update sample-code/spring-app/src/main/resources/static/index.html
4ded890 
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
CharlesDuboisSAP
CharlesDuboisSAP reviewed Jul 23, 2026
View reviewed changes

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good

Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java Outdated
Comment thread orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationReasoningContentTest.java
@n-o-u-r-h-a-n n-o-u-r-h-a-n mentioned this pull request Jul 23, 2026
Open
@CharlesDuboisSAP
CharlesDuboisSAP merged commit a21386b into main Jul 24, 2026
6 checks passed
@CharlesDuboisSAP
CharlesDuboisSAP deleted the reasoning-content branch July 24, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZhongpinWang ZhongpinWang ZhongpinWang left review comments
@Jonas-Isr Jonas-Isr Jonas-Isr left review comments
@CharlesDuboisSAP CharlesDuboisSAP CharlesDuboisSAP approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@n-o-u-r-h-a-n @ZhongpinWang @CharlesDuboisSAP @Jonas-Isr @bot-sdk-js